Conversation
* Still has some failing tests * No benchmarks * No tests for unary ops * No support for functions with arity > 2 (what even are these functions)
…rse dok conversion
Collaborator
|
Thanks for this, @ivirshup. Let me know if you need any help or direction. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #465 +/- ##
==========================================
- Coverage 92.15% 90.91% -1.24%
==========================================
Files 20 21 +1
Lines 3313 3445 +132
==========================================
+ Hits 3053 3132 +79
- Misses 260 313 +53 |
There was a problem hiding this comment.
CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Collaborator
|
@ivirshup Do you plan to continue this? |
Contributor
Author
|
I have some interest but probably not time. I would love for someone to take it over. IIRC the biggest stumbling block was dispatch. If that could get worked out by someone else, I'd be interested in collaborating. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very WIP draft PR for elemwise operations on CSR and CSC arrays.
Currently just implements broadcasting operations between compressed 2d arrays. Cases that would be covered by a full implementation:
-a)A quick benchmark:
Should provide some insight for #460